Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: remove forloop var pass by reference #1073

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Nov 11, 2024

Sucessful testVerifyEnviromentRegistrars with patch:

=== RUN   TestNewEnvironment
=== RUN   TestNewEnvironment/Verify_Multi_Registrar_Environment
--- PASS: TestNewEnvironment/Verify_Multi_Registrar_Environment (0.00s)
--- PASS: TestNewEnvironment (0.00s)
PASS
ok      github.com/xmidt-org/webpa-common/v2/service/consul     0.019s

Failure testVerifyEnviromentRegistrars with forloop bug:

panic:
assert: mock: The method has been called over 1 times.
        Either do one more Mock.On("Register").Return(...), or remove extra call.
        This call was unexpected:
                Register(*api.AgentServiceRegistration)
                0: &api.AgentServiceRegistration{Kind:"", ID:"api:deadbeef", Name:"deadbeef-api", Tags:[]string{"role=deadbeef, region=1"}, Port:443, Address:"deadbeef.com", SocketPath:"", TaggedAddresses:map[string]api.ServiceAddress(nil), EnableTagOverride:false, Meta:map[string]string(nil), Weights:(*api.AgentWeights)(nil), Check:(*api.AgentServiceCheck)(nil), Checks:api.AgentServiceChecks(nil), Proxy:(*api.AgentServiceConnectProxyConfig)(nil), Connect:(*api.AgentServiceConnect)(nil), Namespace:"", Partition:"", Locality:(*api.Locality)(nil)}
        at: [/Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/mocks_test.go:60 /Users/odc/go/pkg/mod/github.com/go-kit/[email protected]/sd/consul/registrar.go:30 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/registrars.go:13 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/environment.go:198 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/environment_test.go:191] [recovered]
        panic:
assert: mock: The method has been called over 1 times.
        Either do one more Mock.On("Register").Return(...), or remove extra call.
        This call was unexpected:
                Register(*api.AgentServiceRegistration)
                0: &api.AgentServiceRegistration{Kind:"", ID:"api:deadbeef", Name:"deadbeef-api", Tags:[]string{"role=deadbeef, region=1"}, Port:443, Address:"deadbeef.com", SocketPath:"", TaggedAddresses:map[string]api.ServiceAddress(nil), EnableTagOverride:false, Meta:map[string]string(nil), Weights:(*api.AgentWeights)(nil), Check:(*api.AgentServiceCheck)(nil), Checks:api.AgentServiceChecks(nil), Proxy:(*api.AgentServiceConnectProxyConfig)(nil), Connect:(*api.AgentServiceConnect)(nil), Namespace:"", Partition:"", Locality:(*api.Locality)(nil)}
        at: [/Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/mocks_test.go:60 /Users/odc/go/pkg/mod/github.com/go-kit/[email protected]/sd/consul/registrar.go:30 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/registrars.go:13 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/environment.go:198 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/environment_test.go:191]

@denopink denopink added the bug label Nov 11, 2024
@denopink denopink self-assigned this Nov 11, 2024
@denopink denopink force-pushed the denopink/patch/service/consul-forloopRefVar-bug branch from 240d9c1 to 8ab6c62 Compare November 11, 2024 18:54
Sucessful `testVerifyEnviromentRegistrars` with patch:

```
=== RUN   TestNewEnvironment
=== RUN   TestNewEnvironment/Verify_Multi_Registrar_Environment
--- PASS: TestNewEnvironment/Verify_Multi_Registrar_Environment (0.00s)
--- PASS: TestNewEnvironment (0.00s)
PASS
ok      github.com/xmidt-org/webpa-common/v2/service/consul     0.019s

```

Failure `testVerifyEnviromentRegistrars` with forloop bug:

```
panic:
assert: mock: The method has been called over 1 times.
        Either do one more Mock.On("Register").Return(...), or remove extra call.
        This call was unexpected:
                Register(*api.AgentServiceRegistration)
                0: &api.AgentServiceRegistration{Kind:"", ID:"api:deadbeef", Name:"deadbeef-api", Tags:[]string{"role=deadbeef, region=1"}, Port:443, Address:"deadbeef.com", SocketPath:"", TaggedAddresses:map[string]api.ServiceAddress(nil), EnableTagOverride:false, Meta:map[string]string(nil), Weights:(*api.AgentWeights)(nil), Check:(*api.AgentServiceCheck)(nil), Checks:api.AgentServiceChecks(nil), Proxy:(*api.AgentServiceConnectProxyConfig)(nil), Connect:(*api.AgentServiceConnect)(nil), Namespace:"", Partition:"", Locality:(*api.Locality)(nil)}
        at: [/Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/mocks_test.go:60 /Users/odc/go/pkg/mod/github.com/go-kit/[email protected]/sd/consul/registrar.go:30 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/registrars.go:13 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/environment.go:198 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/environment_test.go:191] [recovered]
        panic:
assert: mock: The method has been called over 1 times.
        Either do one more Mock.On("Register").Return(...), or remove extra call.
        This call was unexpected:
                Register(*api.AgentServiceRegistration)
                0: &api.AgentServiceRegistration{Kind:"", ID:"api:deadbeef", Name:"deadbeef-api", Tags:[]string{"role=deadbeef, region=1"}, Port:443, Address:"deadbeef.com", SocketPath:"", TaggedAddresses:map[string]api.ServiceAddress(nil), EnableTagOverride:false, Meta:map[string]string(nil), Weights:(*api.AgentWeights)(nil), Check:(*api.AgentServiceCheck)(nil), Checks:api.AgentServiceChecks(nil), Proxy:(*api.AgentServiceConnectProxyConfig)(nil), Connect:(*api.AgentServiceConnect)(nil), Namespace:"", Partition:"", Locality:(*api.Locality)(nil)}
        at: [/Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/mocks_test.go:60 /Users/odc/go/pkg/mod/github.com/go-kit/[email protected]/sd/consul/registrar.go:30 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/registrars.go:13 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/environment.go:198 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/environment_test.go:191]
```
@denopink denopink force-pushed the denopink/patch/service/consul-forloopRefVar-bug branch from 8ab6c62 to 01cd46e Compare November 11, 2024 19:18
@schmidtw schmidtw merged commit 958e263 into main Nov 11, 2024
16 checks passed
@schmidtw schmidtw deleted the denopink/patch/service/consul-forloopRefVar-bug branch November 11, 2024 20:05
denopink added a commit to xmidt-org/talaria that referenced this pull request Nov 11, 2024
includes the following patch:
```
patch: remove forloop var pass by reference
```
xmidt-org/webpa-common#1073
denopink added a commit to xmidt-org/talaria that referenced this pull request Nov 11, 2024
includes the following patch:
```
patch: remove forloop var pass by reference
```
xmidt-org/webpa-common#1073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants