-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: remove forloop var pass by reference #1073
Merged
schmidtw
merged 1 commit into
main
from
denopink/patch/service/consul-forloopRefVar-bug
Nov 11, 2024
Merged
patch: remove forloop var pass by reference #1073
schmidtw
merged 1 commit into
main
from
denopink/patch/service/consul-forloopRefVar-bug
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denopink
force-pushed
the
denopink/patch/service/consul-forloopRefVar-bug
branch
from
November 11, 2024 18:54
240d9c1
to
8ab6c62
Compare
Sucessful `testVerifyEnviromentRegistrars` with patch: ``` === RUN TestNewEnvironment === RUN TestNewEnvironment/Verify_Multi_Registrar_Environment --- PASS: TestNewEnvironment/Verify_Multi_Registrar_Environment (0.00s) --- PASS: TestNewEnvironment (0.00s) PASS ok github.com/xmidt-org/webpa-common/v2/service/consul 0.019s ``` Failure `testVerifyEnviromentRegistrars` with forloop bug: ``` panic: assert: mock: The method has been called over 1 times. Either do one more Mock.On("Register").Return(...), or remove extra call. This call was unexpected: Register(*api.AgentServiceRegistration) 0: &api.AgentServiceRegistration{Kind:"", ID:"api:deadbeef", Name:"deadbeef-api", Tags:[]string{"role=deadbeef, region=1"}, Port:443, Address:"deadbeef.com", SocketPath:"", TaggedAddresses:map[string]api.ServiceAddress(nil), EnableTagOverride:false, Meta:map[string]string(nil), Weights:(*api.AgentWeights)(nil), Check:(*api.AgentServiceCheck)(nil), Checks:api.AgentServiceChecks(nil), Proxy:(*api.AgentServiceConnectProxyConfig)(nil), Connect:(*api.AgentServiceConnect)(nil), Namespace:"", Partition:"", Locality:(*api.Locality)(nil)} at: [/Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/mocks_test.go:60 /Users/odc/go/pkg/mod/github.com/go-kit/[email protected]/sd/consul/registrar.go:30 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/registrars.go:13 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/environment.go:198 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/environment_test.go:191] [recovered] panic: assert: mock: The method has been called over 1 times. Either do one more Mock.On("Register").Return(...), or remove extra call. This call was unexpected: Register(*api.AgentServiceRegistration) 0: &api.AgentServiceRegistration{Kind:"", ID:"api:deadbeef", Name:"deadbeef-api", Tags:[]string{"role=deadbeef, region=1"}, Port:443, Address:"deadbeef.com", SocketPath:"", TaggedAddresses:map[string]api.ServiceAddress(nil), EnableTagOverride:false, Meta:map[string]string(nil), Weights:(*api.AgentWeights)(nil), Check:(*api.AgentServiceCheck)(nil), Checks:api.AgentServiceChecks(nil), Proxy:(*api.AgentServiceConnectProxyConfig)(nil), Connect:(*api.AgentServiceConnect)(nil), Namespace:"", Partition:"", Locality:(*api.Locality)(nil)} at: [/Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/mocks_test.go:60 /Users/odc/go/pkg/mod/github.com/go-kit/[email protected]/sd/consul/registrar.go:30 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/registrars.go:13 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/environment.go:198 /Users/odc/Documents/GitHub/xmidt-org/webpa-common/service/consul/environment_test.go:191] ```
denopink
force-pushed
the
denopink/patch/service/consul-forloopRefVar-bug
branch
from
November 11, 2024 19:18
8ab6c62
to
01cd46e
Compare
schmidtw
approved these changes
Nov 11, 2024
denopink
added a commit
to xmidt-org/talaria
that referenced
this pull request
Nov 11, 2024
includes the following patch: ``` patch: remove forloop var pass by reference ``` xmidt-org/webpa-common#1073
denopink
added a commit
to xmidt-org/talaria
that referenced
this pull request
Nov 11, 2024
includes the following patch: ``` patch: remove forloop var pass by reference ``` xmidt-org/webpa-common#1073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sucessful
testVerifyEnviromentRegistrars
with patch:Failure
testVerifyEnviromentRegistrars
with forloop bug: